Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the DMG creation process for macOS builds by removing the dmg-builder npm package dependency and replacing it with a direct integration of dmgbuild from its GitHub repository. The changes involve setting up a Python virtual environment, cloning dmgbuild from source, and converting the settings format from JSON to Python.
Changes:
- Removed
dmg-buildernpm dependency frombuild/package.jsonand all its transitive dependencies frombuild/package-lock.json - Refactored
build/darwin/create-dmg.tsto clone dmgbuild from GitHub, set up a Python virtual environment, and invoke dmgbuild directly - Updated Azure Pipeline configurations to remove the manual
pyobjc-framework-Quartzinstallation step - Added
.dmgbuilddirectory to.gitignoreto exclude the cloned repository and virtual environment
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| build/package.json | Removed dmg-builder dependency |
| build/package-lock.json | Removed dmg-builder and all transitive dependencies (approximately 250+ packages) |
| build/darwin/create-dmg.ts | Complete refactor to clone and use dmgbuild from GitHub with Python venv |
| build/azure-pipelines/darwin/steps/product-build-darwin-compile.yml | Removed manual pyobjc-framework-Quartz installation |
| build/azure-pipelines/darwin/product-build-darwin-universal.yml | Removed manual pyobjc-framework-Quartz installation |
| .gitignore | Added build/darwin/.dmgbuild to ignore list |
deepak1556
force-pushed
the
robo/refactor_dmgbuild_dependency
branch
2 times, most recently
from
34c8011 to
98538f0
Compare
deepak1556
force-pushed
the
robo/refactor_dmgbuild_dependency
branch
from
98538f0 to
7da9a72
Compare
Collaborator
Author
deepak1556
force-pushed
the
robo/refactor_dmgbuild_dependency
branch
from
6339e5d to
76eb95b
Compare
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
lszomoru
approved these changes
Feb 20, 2026
joaomoreno
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.