Fix bug with diff editor not wrapping red lines.#292094
Open
Andrew199617 wants to merge 2 commits intomicrosoft:mainfrom
Open
Fix bug with diff editor not wrapping red lines.#292094Andrew199617 wants to merge 2 commits intomicrosoft:mainfrom
Andrew199617 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the original (left/red) side of the diff editor was not respecting word wrap settings in side-by-side view. The fix ensures that wordWrapOverride2 is set in addition to wordWrapOverride1, maintaining consistency with how word wrap is disabled in inline mode.
Changes:
- Added
wordWrapOverride2assignment in the left-hand side editor configuration to properly enable word wrap for the original side of the diff editor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Im creating an extension that opens diffs for p4 files. I noticed that red lines in diff editor dont get wrapped in a lot of scenarios. #256329 is an example of a place where the word wrap would not work. For me its easy to reproduce by just opening a fresh vscode with no extensions and then opening a diff on any file. If you have wrap on the modified side, the original side still wont follow that.
Here is what it looks like before my changes. Take note of line 160 on the left side. It is not wrapped when it should be. I have wrapping enabled on the modified side. Both sides are meant to have the same wrapping style.

Here is an example of what it looks like when its working because we are making sure result.wordWrapOverride2 is also set.

Some more details for repro.