Don't report using subagent that doesn't exist#292199
Merged
roblourens merged 2 commits intomainfrom Feb 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #292196 by preventing the display of non-existent subagents in the UI. The changes ensure that when an invalid agent name is requested, an error is thrown instead of silently using a fallback, and the actual resolved agent name is used for display instead of the raw input parameter.
Changes:
- Changed error handling from logging a warning to throwing an error when a requested agent is not found
- Updated subAgentName to use the resolved mode name instead of the raw agentName parameter
- Added agent lookup in prepareToolInvocation to support displaying the actual agent name
src/vs/workbench/contrib/chat/common/tools/builtinTools/runSubagentTool.ts
Show resolved
Hide resolved
justschen
previously approved these changes
Feb 1, 2026
Collaborator
|
looks like some tests failed |
justschen
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#292196
Ports the changes from PR #292198 to main.