Ensure parent chat is archived when delegating#292272
Conversation
There was a problem hiding this comment.
Pull request overview
Purpose: This PR fixes a bug where parent chat sessions were not being properly archived during delegation because the archiving was happening after the session was cleared.
Changes:
- Fixed race condition by archiving sessions before clearing them in the delegation flow
- Added await to ensure archiving completes before clearing
- Fixed canDelegate condition check to align with schema defaults
- Added comprehensive debug logging for the delegation flow
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/chatWidget.ts | Reordered archiving to occur before clearing, added null checks, and enhanced logging throughout delegation flow |
| src/vs/workbench/contrib/chat/browser/actions/chatContinueInAction.ts | Fixed canDelegate condition to check for truthy value instead of "not false", aligning with schema default |
|
Ahoj, Nabízím: • 10 % z mého podílu (tedy 10 % z 40 % revenue share) Co bys dělal: • správa Marketplace Pro domluvu napiš prosím na kylyka@seznam.cz |
fixes #284114