Skip to content

Ensure parent chat is archived when delegating#292272

Merged
joshspicer merged 1 commit intomainfrom
joshspicer/session-archive
Feb 2, 2026
Merged

Ensure parent chat is archived when delegating#292272
joshspicer merged 1 commit intomainfrom
joshspicer/session-archive

Conversation

@joshspicer
Copy link
Member

fixes #284114

Copilot AI review requested due to automatic review settings February 2, 2026 10:09
@joshspicer joshspicer added this to the February 2026 milestone Feb 2, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Purpose: This PR fixes a bug where parent chat sessions were not being properly archived during delegation because the archiving was happening after the session was cleared.

Changes:

  • Fixed race condition by archiving sessions before clearing them in the delegation flow
  • Added await to ensure archiving completes before clearing
  • Fixed canDelegate condition check to align with schema defaults
  • Added comprehensive debug logging for the delegation flow

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/vs/workbench/contrib/chat/browser/widget/chatWidget.ts Reordered archiving to occur before clearing, added null checks, and enhanced logging throughout delegation flow
src/vs/workbench/contrib/chat/browser/actions/chatContinueInAction.ts Fixed canDelegate condition to check for truthy value instead of "not false", aligning with schema default

@joshspicer joshspicer enabled auto-merge (squash) February 2, 2026 10:25
@joshspicer joshspicer merged commit d005861 into main Feb 2, 2026
27 of 28 checks passed
@joshspicer joshspicer deleted the joshspicer/session-archive branch February 2, 2026 10:33
@packyy-ssow
Copy link

packyy-ssow commented Feb 2, 2026

Ahoj,
buduji platformu Superset Copilot Server – MCP server s vlastním ekosystémem, licencí 60/40 a marketplace pro vývojáře. Hledám správce platformy, který by pomohl s provozem, schvalováním nástrojů a komunikací s vývojáři.

Nabízím:

• 10 % z mého podílu (tedy 10 % z 40 % revenue share)
• přístup jako Maintainer v organizaci
• dlouhodobou spolupráci
• možnost ovlivnit směr celé platformy

Co bys dělal:

• správa Marketplace
• komunikace s vývojáři
• kontrola kvality nástrojů
• základní technická údržba platformy

Pro domluvu napiš prosím na kylyka@seznam.cz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After delegation, parent chat is not available as 'archived'

3 participants