Skip to content

Conversation

@deepak1556
Copy link
Collaborator

@deepak1556 deepak1556 commented Feb 3, 2026

Follow-up to c8d90ab

Also updates terrapin check to watch subdirs which was the reason in the first place the change made through. Refs https://dev.azure.com/monacotools/Monaco/_build/results?buildId=401174&view=logs&j=61c8ba5e-f291-589b-6b3a-1e92ccee302c&t=304586ba-26bc-5b11-9799-e3cc6a7ce0dc

cc @TylerLeonhardt

@deepak1556 deepak1556 added this to the February 2026 milestone Feb 3, 2026
@deepak1556 deepak1556 self-assigned this Feb 3, 2026
Copilot AI review requested due to automatic review settings February 3, 2026 15:57
@vs-code-engineering
Copy link

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@lszomoru

Matched files:

  • build/azure-pipelines/product-npm-package-validate.yml

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR syncs missing lockfile updates and broadens the product npm package validation to detect package files in subdirectories, preventing mismatched dependency changes from slipping through CI.

Changes:

  • Cleans up test/mcp/package-lock.json to remove unused dependencies and associated node modules, aligning it with the current package.json.
  • Updates the Terrapin/package validation step in product-npm-package-validate.yml to trigger when any package.json or package-lock.json is changed in any subdirectory, not just the repo root.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
test/mcp/package-lock.json Removes entries for now-absent dependencies (@playwright/mcp, playwright, playwright-core, Express/cors typings, etc.) to keep the lockfile consistent and minimal.
build/azure-pipelines/product-npm-package-validate.yml Adjusts the grep pattern so the validation job runs when any package.json or package-lock.json file changes anywhere in the tree.
Files not reviewed (1)
  • test/mcp/package-lock.json: Language not supported

@deepak1556
Copy link
Collaborator Author

@deepak1556 deepak1556 merged commit 2bf84bf into main Feb 3, 2026
28 checks passed
@deepak1556 deepak1556 deleted the robo/fix_lock_files branch February 3, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants