Update monaco to target lib es2024#292638
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Feb 3, 2026
Merged
Conversation
Follow up on microsoft#271145 This aligns monaco with our main tsconfig target. Tries adopting `findLastIndex` to verify
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns Monaco's TypeScript configuration with VS Code's main tsconfig by updating the target from ES2022 to ES2024, and verifies the change by adopting the native findLastIndex method in place of a custom implementation.
Changes:
- Updated Monaco and vscode-dts TypeScript configurations to target ES2024
- Replaced three usages of custom
findLastIdxwith nativeArray.prototype.findLastIndexas verification
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/tsconfig.monaco.json |
Updated TypeScript target from ES2022 to ES2024 |
src/tsconfig.vscode-dts.json |
Updated TypeScript lib from ES2022 to ES2024 |
src/vs/workbench/contrib/notebook/browser/diff/notebookDiffEditor.ts |
Replaced findLastIdx with native findLastIndex for finding the last changed notebook item |
src/vs/workbench/contrib/debug/common/debugModel.ts |
Replaced findLastIdx with native findLastIndex for positioning debug sessions |
src/vs/workbench/contrib/chat/common/widget/annotations.ts |
Replaced findLastIdx with native findLastIndex for locating previous chat content items |
jrieken
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #271145
This aligns monaco with our main tsconfig target. Tries adopting
findLastIndexto verify