Remove notifySessionItemsChanged#292642
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Feb 3, 2026
Merged
Conversation
afaik `notifySessionItemsChanged` is only used in tests and the tests it is used in seem to be testing `notifySessionItemsChanged` 🙃
rzhao271
approved these changes
Feb 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the notifySessionItemsChanged method that was only being used in tests to manually trigger the session items changed event. The method has been removed from the interface, main service implementation, and mock service, along with the tests that were specifically testing this method.
Changes:
- Removed
notifySessionItemsChangedmethod fromIChatSessionsServiceinterface and implementations - Removed two tests that were testing the removed method in
localAgentSessionsProvider.test.ts - Changed return type of
getChatSessionItemsfromIChatSessionItem[]toreadonly IChatSessionItem[]for better immutability guarantees
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/chatSessionsService.ts | Removed notifySessionItemsChanged from interface and changed array type to readonly in getChatSessionItems return type |
| src/vs/workbench/contrib/chat/browser/chatSessions/chatSessions.contribution.ts | Removed notifySessionItemsChanged implementation from main service |
| src/vs/workbench/contrib/chat/test/common/mockChatSessionsService.ts | Removed notifySessionItemsChanged implementation from mock service |
| src/vs/workbench/contrib/chat/test/browser/agentSessions/localAgentSessionsProvider.test.ts | Removed two tests that were testing the removed method |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
afaik
notifySessionItemsChangedis only used in tests and the tests it is used in seem to be testingnotifySessionItemsChanged🙃