Don't return providers in IChatSessionsService methods#292646
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Feb 3, 2026
Merged
Don't return providers in IChatSessionsService methods#292646mjbvz merged 1 commit intomicrosoft:mainfrom
IChatSessionsService methods#292646mjbvz merged 1 commit intomicrosoft:mainfrom
Conversation
Further trying to clean up interface so that `IChatSessionsService` consumers don't know about providers directly
lszomoru
approved these changes
Feb 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up the IChatSessionsService interface by changing activateChatSessionItemProvider to no longer expose providers directly to consumers. The method's return type is changed from Promise<IChatSessionItemProvider | undefined> to Promise<void>.
Changes:
- Modified the
IChatSessionsServiceinterface to changeactivateChatSessionItemProviderreturn type toPromise<void> - Created a new private
doActivateChatSessionItemProvidermethod that returns the provider for internal use - Updated the mock implementation to match the new interface signature
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/chatSessionsService.ts | Updated interface signature for activateChatSessionItemProvider to return Promise<void> |
| src/vs/workbench/contrib/chat/browser/chatSessions/chatSessions.contribution.ts | Introduced private doActivateChatSessionItemProvider method for internal use and updated the public method to delegate without returning the provider |
| src/vs/workbench/contrib/chat/test/common/mockChatSessionsService.ts | Updated mock implementation to match new interface signature with noop implementation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further trying to clean up interface so that
IChatSessionsServiceconsumers don't know about providers directly