BUILD: Revert "build: always repackage electron from oss entry scripts (#292770)"#292812
Merged
deepak1556 merged 1 commit intomainfrom Feb 4, 2026
Merged
BUILD: Revert "build: always repackage electron from oss entry scripts (#292770)"#292812deepak1556 merged 1 commit intomainfrom
deepak1556 merged 1 commit intomainfrom
Conversation
)" This reverts commit fef6f5a.
deepak1556
approved these changes
Feb 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts a previous commit (fef6f5a) that introduced VSCODE_SKIP_PRELAUNCH environment variable workarounds. The revert removes these workarounds and restores version checking logic to avoid unnecessarily re-downloading Electron.
Changes:
- Restored version checking in electron download script to skip re-downloading when Electron is already up-to-date
- Removed
VSCODE_SKIP_PRELAUNCHenvironment variable from policy export integration test - Removed
VSCODE_SKIP_PRELAUNCHenvironment variable from vscode-test-resolver extension
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| build/lib/electron.ts | Adds version file checking to avoid re-downloading Electron when already up-to-date |
| src/vs/workbench/contrib/policyExport/test/node/policyExport.integrationTest.ts | Removes VSCODE_SKIP_PRELAUNCH environment variable and associated comment from test execution |
| extensions/vscode-test-resolver/src/extension.ts | Removes VSCODE_SKIP_PRELAUNCH environment variable assignment from server launch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit fef6f5a.