Fix bug in inlineCompletionsModel.ts#292824
Open
a-stewart wants to merge 1 commit intomicrosoft:mainfrom
Open
Conversation
hediet
approved these changes
Mar 17, 2026
Member
|
Thanks! |
jrieken
approved these changes
Mar 17, 2026
Contributor
Author
|
Thanks for the review - I think that you will need to merge it too though and approve running the tests as I don't have permissions to do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this._getMetadataaccepts arguments,completion: InlineSuggestionItem, languageId: string, type: 'word' | 'line' | undefined = undefinedThe second argument is
languageId: string.On line 1099, it is called with
this._getMetadata(completion, type)which is allowed beforetypeis optional, and'word' | 'line'is a valid string.The result of this is an event is fired with langaugeId set as
wordorline.This PR fixes that trivially.
A better solution though would likely be to remove
language: stringfrom the method entirely, sincethis.textModel.getLanguageId()is available from within the method anyway.