Skip to content

Do not update agent status indicator bg color when debugging#292905

Merged
joshspicer merged 4 commits intomainfrom
josh/agent-indicator-no-debug
Feb 5, 2026
Merged

Do not update agent status indicator bg color when debugging#292905
joshspicer merged 4 commits intomainfrom
josh/agent-indicator-no-debug

Conversation

@joshspicer
Copy link
Member

image

Copilot AI review requested due to automatic review settings February 4, 2026 19:12
@vs-code-engineering
Copy link

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

  • src/vs/workbench/contrib/chat/browser/agentSessions/experiments/media/agenttitlebarstatuswidget.css

@joshspicer joshspicer changed the title Do not update agent status inicator bg color when debugging Do not update agent status indicator bg color when debugging Feb 4, 2026
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 4, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts Agent Session titlebar status widget styling so its background does not change when debug mode updates Command Center colors.

Changes:

  • Replaces var(--vscode-commandCenter-background) with fixed translucent rgba(...) backgrounds for the agent status pill and badge.
  • Adds .vs and high-contrast (.hc-black, .hc-light) overrides to tweak/disable the fixed background.
Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/chat/browser/agentSessions/experiments/media/agenttitlebarstatuswidget.css:234

  • Same concern as above: replacing var(--vscode-commandCenter-background) with a hardcoded rgba value will ignore theme overrides for commandCenter.background, so the badge can visually diverge from the Command Center in custom themes. It would be more robust to continue using the theme token here and address the debug-mode override at its source (by not overriding commandCenter.background globally, or by introducing a dedicated debug-only token/variable).
	background-color: rgba(255, 255, 255, 0.05);
	border: 1px solid var(--vscode-commandCenter-border, transparent);
	flex-shrink: 0;
	-webkit-app-region: no-drag;
	margin-left: auto;

bpasero
bpasero previously requested changes Feb 4, 2026
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be themable?

@joshspicer
Copy link
Member Author

joshspicer commented Feb 4, 2026

@bpasero Is there a correct CSS variable you think makes sense here? var(--vscode-commandCenter-background) is difficult as it changes to the debug color and I wasn't certain how to make changes to it safely to special case my widget

I figured it out

@joshspicer
Copy link
Member Author

@copilot fix this PR sitll be themeable but not have the problem of changing to the 'debug' color

Copy link
Contributor

Copilot AI commented Feb 4, 2026

@joshspicer I've opened a new pull request, #292944, to work on those changes. Once the pull request is ready, I'll request review from you.

…erride (#292944)

* Initial plan

* Add themeable agentStatusIndicator.background color to avoid debug override

Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com>
@joshspicer joshspicer dismissed bpasero’s stale review February 4, 2026 22:46

It is now themeable

@joshspicer
Copy link
Member Author

joshspicer commented Feb 4, 2026

This is what it looks like with every theme i have installed

Screen.Recording.2026-02-04.at.10.33.24.PM.mov

rebornix
rebornix previously approved these changes Feb 4, 2026
@joshspicer joshspicer merged commit 0561e9e into main Feb 5, 2026
22 checks passed
@joshspicer joshspicer deleted the josh/agent-indicator-no-debug branch February 5, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants