improve specificity for chat selector to fix smoketest#292922
Merged
meganrogge merged 1 commit intomainfrom Feb 4, 2026
Merged
improve specificity for chat selector to fix smoketest#292922meganrogge merged 1 commit intomainfrom
meganrogge merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a smoketest failure caused by Playwright finding multiple Monaco editors with role="code" in the chat panel. The fix narrows the CSS selector to specifically target only the chat input editor by adding the .interactive-input-part class to the selector chain.
Changes:
- Renamed
CHAT_EDITORtoCHAT_INPUT_EDITORand updated selector to include.interactive-input-partclass - Renamed
CHAT_EDITOR_FOCUSEDtoCHAT_INPUT_EDITOR_FOCUSEDwith the same specificity improvement - Updated all references to use the new constant names throughout the Chat class
rzhao271
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The smoketest was failing because Playwright found 2 Monaco editors with
role="code"in the chat panel:The fix narrows the selector, ensuring only the chat input editor is targeted.