Remove region diagnostics setting#292955
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Feb 4, 2026
Merged
Conversation
Part of microsoft#292934 This is an implementation detail. Was only really added in 5.6 in case the new behavior caused issues. Should be safe to remove now
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the typescript.tsserver.enableRegionDiagnostics setting, which was added in TypeScript 5.6 as a safety measure but has seen almost zero real usage. The removal simplifies the codebase by treating region diagnostics as an implementation detail rather than a user-configurable option.
Changes:
- Removed
enableRegionDiagnosticsconfiguration property and related code - Simplified region diagnostics logic to only check TypeScript version (≥5.6.0)
- Removed setting definition and localization strings
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| extensions/typescript-language-features/src/tsServer/bufferSyncSupport.ts | Simplified areRegionDiagnosticsEnabled() to only check API version without configuration check |
| extensions/typescript-language-features/src/configuration/configuration.ts | Removed enableRegionDiagnostics from interface and configuration loading logic |
| extensions/typescript-language-features/package.nls.json | Removed localization string for the deprecated setting |
| extensions/typescript-language-features/package.json | Removed setting definition from package configuration |
DonJayamanne
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #292934
This setting was added in 5.6 in case the new behavior caused issues. Should be safe to remove now since it's more of an implementation detail and has almost zero real usage