replace in checks with Object.hasOwn

[meganrogge]

part of #276071

[Copilot]

Pull request overview

This PR replaces the in operator with Object.hasOwn() and converts for...in loops to Object.keys() to comply with a new ESLint rule that disallows the in operator. The changes affect task system components, terminal contribution features, and the terminal-suggest extension.

Changes:

• Replaced in operator checks with Object.hasOwn() for safer property existence checks
• Converted for...in loops to Object.keys() for more predictable iteration
• Added type assertions where needed to maintain type safety after the refactoring
• Removed affected files from the ESLint allowlist

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
eslint.config.js	Removed 10 files from the no-in rule allowlist that are being fixed in this PR
src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts	Converted for...in to Object.keys() in 3 locations; replaced in checks with Object.hasOwn() in 2 locations; improved type guard at line 1414 using CustomTask.is() and ContributedTask.is() instead of in operator
src/vs/workbench/contrib/tasks/browser/taskTerminalStatus.ts	Replaced in operator with Object.hasOwn() for checking terminalId property
src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts	Converted 4 for...in loops to Object.keys(); replaced 3 in operator checks with Object.hasOwn() with appropriate type assertions
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/taskHelpers.ts	Replaced in operator checks with Object.hasOwn() in 5 locations; updated IConfiguredTask interface to include missing properties; added type casts to maintain type safety
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/monitoring/outputMonitor.ts	Refactored JSON parsing validation to use Object.hasOwn() with improved type safety; added null check before property access
extensions/terminal-suggest/src/terminalSuggestMain.ts	Replaced in operator with Object.hasOwn() for checking shell property
extensions/terminal-suggest/src/test/env/pathExecutableCache.test.ts	Replaced in operator with Object.hasOwn() in test assertions
extensions/terminal-suggest/src/fig/figInterface.ts	Added type guard for function before using Object.hasOwn() on spec object; replaced in operator with Object.hasOwn() for args property checks with type assertions
extensions/terminal-suggest/src/fig/fig-autocomplete-shared/specMetadata.ts	Replaced in operator with Object.hasOwn() for type discrimination with explicit return type annotations
extensions/terminal-suggest/src/fig/fig-autocomplete-shared/mixins.ts	Replaced in operator with Object.hasOwn() in filter predicate