Merged
Conversation
Looks like multiple changes started using the wrong uri type. This fixes `new chat editor` but I think a few other callers are doing the same thing. Will follow up with separate PRs
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where chat editor opening actions were incorrectly using editor input URIs instead of session URIs. The fix adds a new helper method to generate session URIs and updates the "New Chat Editor" and "New Chat Window" actions to use it.
Changes:
- Added
LocalChatSessionUri.getNewSessionUri()helper method to generate new session URIs - Updated "New Chat Editor" action to use session URI instead of editor input URI
- Updated "New Chat Window" action to use session URI instead of editor input URI
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/model/chatUri.ts | Added getNewSessionUri() helper method that generates a new local chat session URI with a random handle |
| src/vs/workbench/contrib/chat/browser/actions/chatActions.ts | Updated imports to include ACTIVE_GROUP and LocalChatSessionUri, and modified two action implementations to use LocalChatSessionUri.getNewSessionUri() with proper group targeting |
justschen
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like multiple changes are using the chat editor input uri type to instead of the session uri. This fixes
new chat editorbut I think a few other callers are doing the same thing. Will follow up with separate PRsNot 100% sure why this only recently started happening since the changes have been in multiple weeks but this fix is the correct modern way to do this