Skip to content

Fix opening chat editors#292983

Merged
mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz:dev/mjbvz/curved-primate
Feb 5, 2026
Merged

Fix opening chat editors#292983
mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz:dev/mjbvz/curved-primate

Conversation

@mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Feb 5, 2026

Looks like multiple changes are using the chat editor input uri type to instead of the session uri. This fixes new chat editor but I think a few other callers are doing the same thing. Will follow up with separate PRs

Not 100% sure why this only recently started happening since the changes have been in multiple weeks but this fix is the correct modern way to do this

Looks like multiple changes started using the wrong uri type. This fixes `new chat editor` but I think a few other callers are doing the same thing. Will follow up with separate PRs
Copilot AI review requested due to automatic review settings February 5, 2026 00:55
@mjbvz mjbvz enabled auto-merge February 5, 2026 00:56
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 5, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where chat editor opening actions were incorrectly using editor input URIs instead of session URIs. The fix adds a new helper method to generate session URIs and updates the "New Chat Editor" and "New Chat Window" actions to use it.

Changes:

  • Added LocalChatSessionUri.getNewSessionUri() helper method to generate new session URIs
  • Updated "New Chat Editor" action to use session URI instead of editor input URI
  • Updated "New Chat Window" action to use session URI instead of editor input URI

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/vs/workbench/contrib/chat/common/model/chatUri.ts Added getNewSessionUri() helper method that generates a new local chat session URI with a random handle
src/vs/workbench/contrib/chat/browser/actions/chatActions.ts Updated imports to include ACTIVE_GROUP and LocalChatSessionUri, and modified two action implementations to use LocalChatSessionUri.getNewSessionUri() with proper group targeting

@mjbvz mjbvz merged commit ab2c900 into microsoft:main Feb 5, 2026
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants