Fix/resource leak osreleaseinfo#293027
Merged
deepak1556 merged 6 commits intomicrosoft:mainfrom Feb 5, 2026
Merged
Conversation
Fix spelling of "accommodate" in comments across multiple files: - src/vs/editor/common/viewLayout/viewLayout.ts - src/vs/platform/files/node/watcher/parcel/parcelWatcher.ts - src/vs/workbench/common/editor/editorGroupModel.ts
The FileHandle opened for reading os-release files was never closed, which could lead to file descriptor leaks. Added a finally block to ensure the handle is properly closed regardless of success or error. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
deepak1556
approved these changes
Feb 5, 2026
Collaborator
deepak1556
left a comment
deepak1556
left a comment
There was a problem hiding this comment.
Thanks!
But can you separate grammar changes to a different PR
dbaeumer
approved these changes
Feb 5, 2026
Contributor
Author
|
Thank you for the feedback! Since this PR has been approved and all checks have passed, I'd like to merge it now to avoid blocking progress. I'll create a separate PR for the grammar changes in the next few days. |
Contributor
Author
|
PR #293027 (Fix/resource leak osreleaseinfo) is approved (12/12) can you merged it? Thank you! |
deepak1556
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.