Skip to content

Update icons for ipynb and code-workspace file associations on Windows#293037

Merged
dmitrivMS merged 1 commit intomainfrom
dev/dmitriv/windows-file-icons
Feb 5, 2026
Merged

Update icons for ipynb and code-workspace file associations on Windows#293037
dmitrivMS merged 1 commit intomainfrom
dev/dmitriv/windows-file-icons

Conversation

@dmitrivMS
Copy link
Contributor

Fixes #105681

Most icons we have are already included and work as expected.
Updated ipynb extension to use python icon.
Updated code-workspace extension to use primary VS Code icon.

Copilot AI review requested due to automatic review settings February 5, 2026 07:58
@dmitrivMS dmitrivMS added this to the February 2026 milestone Feb 5, 2026
@dmitrivMS dmitrivMS enabled auto-merge (squash) February 5, 2026 07:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Windows file association icons for .ipynb (Jupyter Notebook) and .code-workspace files to use more appropriate icons instead of the generic default icon. The changes address issue #105681 where .ipynb files were displaying a blank icon.

Changes:

  • Updated .ipynb files to use the Python icon (python.ico) instead of the default icon
  • Updated .code-workspace files to use the primary VS Code icon (code.ico) instead of the default icon
  • Added code.ico to the Windows packaging build script to ensure it's included in the installer

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
build/win32/code.iss Updated DefaultIcon registry entries for .code-workspace and .ipynb file associations to use code.ico and python.ico respectively
build/gulpfile.vscode.ts Added code.ico to the list of Windows icon files to be included in the package

@dmitrivMS dmitrivMS assigned dmitrivMS and unassigned joaomoreno and deepak1556 Feb 5, 2026
@dmitrivMS dmitrivMS added install-update VS Code installation and upgrade system issues windows VS Code on Windows issues labels Feb 5, 2026
@dmitrivMS dmitrivMS merged commit e6fdfd7 into main Feb 5, 2026
37 of 39 checks passed
@dmitrivMS dmitrivMS deleted the dev/dmitriv/windows-file-icons branch February 5, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

install-update VS Code installation and upgrade system issues windows VS Code on Windows issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows: VS Code File icons are missing

3 participants