Skip flaky test " setTextDocumentLanguage for notebook cells"#293072
Merged
Skip flaky test " setTextDocumentLanguage for notebook cells"#293072
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR skips a flaky test related to setting the language of notebook cells. The test is intermittently failing with assertion errors where the document URI doesn't match the expected notebook cell URI.
Changes:
- Adds
.skipto the test "setTextDocumentLanguage for notebook cells" to temporarily disable it while the underlying flakiness (issue #292792) is being investigated
| }); | ||
|
|
||
| test('setTextDocumentLanguage for notebook cells', async function () { | ||
| test.skip('setTextDocumentLanguage for notebook cells', async function () { |
There was a problem hiding this comment.
The skipped test should include an inline comment with the issue reference, following the codebase convention for flaky tests. For example, as seen in extensions/vscode-api-tests/src/singlefolder-tests/debug.test.ts:66, flaky tests include a comment in the format: // Flaky: https://github.com/microsoft/vscode/issues/ISSUE_NUMBER. This test should have a comment like // Flaky: https://github.com/microsoft/vscode/issues/292792 at the end of the line.
joaomoreno
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #292792