Fix for extension button separator wrong color precedence#293120
Open
EmrecanKaracayir wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix for extension button separator wrong color precedence#293120EmrecanKaracayir wants to merge 1 commit intomicrosoft:mainfrom
EmrecanKaracayir wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the CSS variable precedence for the extension button separator color. The issue was that when both extensionButton.border and extensionButton.separator theme tokens were customized, the separator was incorrectly using the border color instead of the separator color.
Changes:
- Swapped the CSS variable fallback order in
extensionActions.cssto prioritizeextensionButton.separatoroverextensionButton.border
mrleemurray
approved these changes
Feb 6, 2026
Contributor
|
Thanks @EmrecanKaracayir ! |
chrmarti
approved these changes
Feb 6, 2026
Collaborator
|
Moving this to 1.112 and disabling auto merge so that we can get the 1.111 milestone into good shape by the end of Thursday Please take this in as a candidate if it must go into 1.111 |
Contributor
|
Waiting till 1.112 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #293118