fix: remove transparent quickInput.background in Dark Modern theme (fix #293097)

[murataslan1]

PR Title

fix: remove transparent quickInput.background in Dark Modern theme (fix #293097)

Description

Fixes issue #293097 where the Command Palette (Quick Pick) became transparent in the "Dark Modern" theme, making it unreadable.

The issue was caused by an explicit definition of "quickInput.background": "#222222" in extensions/theme-defaults/themes/dark_modern.json. Although the color value itself is opaque, its presence seemed to interfere with the expected widget styling or fallback behavior.

By removing this explicit definition, the theme now correctly inherits editorWidget.background from the base theme (or default behavior), which resolves to #202020 in this context. This matches the behavior of "Dark+" and restores the expected opacity.

Changes:

• Removed quickInput.background from extensions/theme-defaults/themes/dark_modern.json.

Related Issue

Fixes #293097

[Copilot]

Pull request overview

This PR addresses issue #293097 where the Command Palette (Quick Pick) became transparent in the "Dark Modern" theme, making it unreadable when viewing bright content. The fix removes the explicit quickInput.background color definition, allowing the theme to fall back to the inherited editorWidget.background value.

Changes:

• Removed quickInput.background from the Dark Modern theme to fix transparency issues

[Copilot]

The removal of quickInput.background from this theme file should be accompanied by a corresponding update to COLOR_THEME_DARK_INITIAL_COLORS in src/vs/workbench/services/themes/common/workbenchThemeService.ts. Currently, the initial colors (used to prevent paint flashing during startup) still define quickInput.background as #222222, which creates an inconsistency where the initial rendering will use #222222 but after the theme loads it will fall back to editorWidget.background (#202020). This inconsistency could cause a visual flash when the theme fully loads.

Suggested change

	"progressBar.background": "#0078D4",
	"progressBar.background": "#0078D4",
	"quickInput.background": "#222222",

[Copilot]

For consistency, consider also removing quickInput.background from light_modern.json since it's set to #F8F8F8 which is identical to editorWidget.background in that theme. This would make both modern themes follow the same pattern of inheriting from editorWidget.background. Note that the corresponding COLOR_THEME_LIGHT_INITIAL_COLORS would also need to be updated.

Suggested change

"quickInput.foreground": "#CCCCCC",