Fixes button.secondaryBorder theme token discarded for secondary buttons#293241
Open
EmrecanKaracayir wants to merge 4 commits intomicrosoft:mainfrom
Open
Fixes button.secondaryBorder theme token discarded for secondary buttons#293241EmrecanKaracayir wants to merge 4 commits intomicrosoft:mainfrom
button.secondaryBorder theme token discarded for secondary buttons#293241EmrecanKaracayir wants to merge 4 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request attempts to fix issue #293240 where the button.secondaryBorder theme token was not being used for secondary buttons. The issue reported that secondary buttons were incorrectly using the button.border theme token instead of button.secondaryBorder.
Changes:
- Added
buttonSecondaryBorderto the imports fromcolorRegistry.ts - Modified the
buttonBorderproperty mapping indefaultButtonStylesto usebuttonSecondaryBordertheme token
Contributor
|
@EmrecanKaracayir can you please resolve the conflicts? |
Contributor
Author
|
Sorry for the late reply. I resolved conflicts. |
aeschli
approved these changes
Mar 26, 2026
bpasero
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #293240