Enhance preToolUse hook and clean up code #293265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the preToolUse hook system by introducing a new 'ask' permission decision option, alongside the existing 'allow' and 'deny' options. The 'ask' decision forces user confirmation for tool execution even when auto-approval would normally apply. The implementation includes comprehensive test coverage and minor code cleanup.
Changes:
- Added 'ask' as a third permission decision for preToolUse hooks (along with 'allow' and 'deny')
- Implemented priority handling: deny > ask > allow
- Added
forceConfirmationReasonfield to tool invocation context to signal tools when confirmation is required - Updated hook execution logic to validate hookEventName and handle the new 'ask' decision
- Reorganized imports in hooksExecutionService.ts for better readability
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/vscode-dts/vscode.proposed.chatParticipantPrivate.d.ts | Added forceConfirmationReason optional field to LanguageModelToolInvocationPrepareOptions |
| src/vs/workbench/contrib/chat/common/hooks/hooksTypes.ts | Added 'ask' to PreToolUsePermissionDecision type with documentation |
| src/vs/workbench/contrib/chat/common/hooks/hooksExecutionService.ts | Implemented 'ask' handling with priority logic and hookEventName validation; reorganized imports |
| src/vs/workbench/contrib/chat/common/tools/languageModelToolsService.ts | Added forceConfirmationReason field and logic to handle 'ask' decision |
| src/vs/workbench/contrib/chat/browser/tools/languageModelToolsService.ts | Refactored preToolUse hook handling to return both denial and hook results; added resolveAutoConfirmFromHook method |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts | Updated confirmation logic to respect forceConfirmationReason |
| src/vs/workbench/api/common/extHostLanguageModelTools.ts | Added forceConfirmationReason to extension host integration with API check |
| src/vs/workbench/contrib/chat/test/common/hooksExecutionService.test.ts | Added comprehensive tests for 'ask' decision and priority handling |
| src/vs/workbench/contrib/chat/test/browser/tools/languageModelToolsService.test.ts | Added integration tests for 'ask' and 'allow' decisions |
| chatSessionId?: string; | ||
| chatSessionResource: URI | undefined; | ||
| chatInteractionId?: string; | ||
| /** If set, tells the tool that it should include confirmmation messages. */ |
There was a problem hiding this comment.
Spelling error: "confirmmation" should be "confirmation".
DonJayamanne
approved these changes
Feb 6, 2026
daviddossett
pushed a commit
to daviddossett/vscode
that referenced
this pull request
Feb 7, 2026
* Flesh out preToolUse hook * Cleanup * cleanups * Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes improve the preToolUse hook by adding a new permission decision option and ensuring confirmation messages are displayed based on the context. Code cleanup enhances readability and maintainability.