fix edits jumping around and questions appearing above #293302
Merged
+35
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes visual glitches in the chat UI where edits would jump around during rendering and question carousels would appear in inappropriate locations during edit mode.
Changes:
- Synchronized blocked state management between requests and their responses in checkpoint operations
- Added auto-scroll suppression during edit operations to prevent unwanted scrolling
- Refined tree rendering identity calculation to check per-element states instead of global states, reducing unnecessary re-renders
- Prevented question carousels from rendering in the input area during edit mode
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/model/chatModel.ts | Added setBlockedState(false) calls for responses in resetCheckpoint() and setCheckpoint() to synchronize blocked state between requests and responses |
| src/vs/workbench/contrib/chat/browser/widget/chatWidget.ts | Set suppressAutoScroll flag to true when starting edits and false when finishing to prevent scroll jumps |
| src/vs/workbench/contrib/chat/browser/widget/chatListWidget.ts | Implemented suppressAutoScroll mechanism and refined diff identity calculation to check per-element blocked state instead of global checkpoint |
| src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts | Added isEditing check to prevent question carousel from rendering in input area during edit mode |
bpasero
approved these changes
Feb 6, 2026
daviddossett
pushed a commit
to daviddossett/vscode
that referenced
this pull request
Feb 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue where some requests would re-render with the wrong height, causing edits to jump around.
also makes sure that the questions carousel doesn't randomly render above the editing input part.