Skip to content

Conversation

@bpasero
Copy link
Member

@bpasero bpasero commented Feb 6, 2026

fix #293332

Copilot AI review requested due to automatic review settings February 6, 2026 08:53
@bpasero bpasero enabled auto-merge (squash) February 6, 2026 08:53
@bpasero bpasero self-assigned this Feb 6, 2026
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 6, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts extension editors from opening in modal editor groups back to opening as regular editors in either the active group or side group based on the sideByside option. This restores the standard editor opening behavior for extension detail pages.

Changes:

  • Replaced MODAL_GROUP with conditional logic that uses SIDE_GROUP when sideByside option is true, or ACTIVE_GROUP otherwise
  • Updated imports to include ACTIVE_GROUP and SIDE_GROUP instead of MODAL_GROUP

@bpasero bpasero merged commit 766e171 into main Feb 6, 2026
27 of 28 checks passed
@bpasero bpasero deleted the ben/spatial-wolf branch February 6, 2026 09:11
daviddossett pushed a commit to daviddossett/vscode that referenced this pull request Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modal window displaying extension has blank Details tab

2 participants