style - update styles for modal editor components #293341
Merged
+10
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the visual styling of the modal editor components to improve their appearance. The changes include adjustments to shadows, spacing, sizing, and layout alignment of the modal editor header.
Changes:
- Updated shadow styling to use themed CSS variables with smaller blur and lighter opacity
- Increased header height from 24px to 32px for better proportions
- Changed title alignment from centered to left-aligned with increased padding
- Added spacing between action buttons in the header
- Added font-weight to the title for improved visual hierarchy
Comments suppressed due to low confidence (1)
src/vs/workbench/browser/parts/editor/media/modalEditorPart.css:60
- The comment "Title element (centered)" in modalEditorPart.ts line 68 is now outdated since the CSS changes left-align the title instead of centering it. This comment should be updated to reflect the new left-aligned layout.
grid-column: 1;
Comment on lines
+52
to
+53
| height: 32px; | ||
| min-height: 32px; |
There was a problem hiding this comment.
The header height is changed from 24px to 32px in CSS, but the TypeScript code in modalEditorPart.ts line 126 still has a hardcoded value of 24 for headerHeight calculation. This will cause incorrect layout calculations and the editor part will be sized incorrectly. The TypeScript code should be updated to match this new height of 32px.
Suggested change
| height: 32px; | |
| min-height: 32px; | |
| height: 24px; | |
| min-height: 24px; |
dmitrivMS
approved these changes
Feb 6, 2026
daviddossett
pushed a commit
to daviddossett/vscode
that referenced
this pull request
Feb 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.