Avoid auto approval for confirmation tool with buttons for background agents#293546
Merged
DonJayamanne merged 1 commit intomainfrom Feb 8, 2026
Merged
Avoid auto approval for confirmation tool with buttons for background agents#293546DonJayamanne merged 1 commit intomainfrom
DonJayamanne merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the chat tools auto-approval logic so that the built-in confirmation tool that presents multiple button options (vscode_get_confirmation_with_options) is never auto-approved, ensuring a user must explicitly choose an option (important for background/agent flows).
Changes:
- Introduces a special-case tool id that is always ineligible for auto-approval.
- Updates default confirmation message preparation to omit the “restricted via settings” disclaimer for that tool.
- Ensures auto-confirm decisions are blocked for that tool even when global auto-approve is enabled.
src/vs/workbench/contrib/chat/browser/tools/languageModelToolsService.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/tools/languageModelToolsService.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/tools/languageModelToolsService.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/tools/languageModelToolsService.ts
Show resolved
Hide resolved
joshspicer
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.