chat setup - improve detection for panel welcome on context keys that are relevant#293603
Merged
chat setup - improve detection for panel welcome on context keys that are relevant#293603
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves the chat setup flow’s detection logic for whether the panel can show a “welcome / guidance” view by only reacting to context key changes that are relevant to the registered welcome descriptors.
Changes:
- Tracks the set of context keys referenced by registered
chatViewsWelcomeRegistrydescriptors. - Filters
onDidChangeContexthandling to only fire when one of those descriptor keys changes.
Contributor
…ry registry reads (#293607) * Initial plan * Optimize context key detection to only update descriptorKeys on registry changes Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>
vijayupadya
approved these changes
Feb 7, 2026
daviddossett
pushed a commit
to daviddossett/vscode
that referenced
this pull request
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.