Fix build error when using tsgo #293923
Merged
Fix build error when using tsgo #293923
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added a dependency between api proposals. Looks like tsgo is more strict about not picking this up automatically so we need to make sure there is an import so the dependency is picked up
Tyriar
approved these changes
Feb 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a stricter tsgo build dependency issue in the proposed VS Code API typings by making vscode.proposed.chatParticipantAdditions.d.ts explicitly depend on vscode.proposed.chatHooks.d.ts.
Changes:
- Add an explicit side-effect import of
vscode.proposed.chatHooks.d.tsfromvscode.proposed.chatParticipantAdditions.d.tssoChatHookTypeis resolved undertsgo. - Update
local/code-import-patternsESLint allowlist sosrc/vscode-dts/**files are permitted to import othersrc/vscode-dts/*files (needed due to the new import).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vscode-dts/vscode.proposed.chatParticipantAdditions.d.ts | Adds an explicit dependency import on chatHooks to satisfy tsgo’s stricter dependency graph. |
| eslint.config.js | Allows intra-src/vscode-dts imports so the new .d.ts import passes local/code-import-patterns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChatParticipantAdditions started using types from chatHooks, but doesn't have an explicit dependency on it. Looks like tsgo is more strict about not picking this up automatically so we need to make sure there is an import so the dependency is picked up