Disable failing tests

[dbaeumer]

Disable tests that are currently failing to prevent disruption in the test suite.

[Copilot]

Pull request overview

This pull request disables three failing tests in the ChatEditsTree test suite without providing explanation or investigation details. The disabled tests cover critical widget lifecycle functionality including storage listener behavior, session state management, and entry replay during view mode transitions.

Changes:

• Disabled three tests in chatEditsTree.test.ts using the .skip() method

Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/chat/test/browser/widget/input/chatEditsTree.test.ts:273

• These disabled tests cover important widget lifecycle behavior. The tests validate:

1. That the storage listener continues to work after clear() is called (line 205-229)
2. That currentSession is properly updated during rebuild() (line 231-245)
3. That entries are replayed correctly when toggling view modes (line 247-273)

These behaviors are critical for the ChatEditsListWidget functionality. Looking at the implementation in chatEditsTree.ts (lines 456-463), the storage listener is set up to recreate the widget and replay entries when the view mode changes. If these tests are failing, it suggests potential bugs in:

• The storage listener registration or disposal
• The session state tracking
• The entry replay mechanism

Disabling these tests without fixing the underlying issue risks shipping broken functionality to users.

		});

		test.skip('currentSession is updated on rebuild', () => {
			// Stub create
			widget.create = (c, s) => {
				(widget as unknown as { _currentContainer: HTMLElement | undefined })._currentContainer = c;
				(widget as unknown as { _currentSession: IChatEditingSession | null })._currentSession = s;
			};

			const container = document.createElement('div');
			widget.create(container, null);
			assert.strictEqual(widget.currentSession, null);

			const mockSession = {} as IChatEditingSession;
			widget.rebuild(container, mockSession);
			assert.strictEqual(widget.currentSession, mockSession);
		});

		test.skip('setEntries replays after view mode toggle', () => {
			// Stub create and track setEntries calls
			widget.create = (c, s) => {
				(widget as unknown as { _currentContainer: HTMLElement | undefined })._currentContainer = c;
				(widget as unknown as { _currentSession: IChatEditingSession | null })._currentSession = s;
			};

			const container = document.createElement('div');
			widget.create(container, null);

			const entries = [makeFileItem('/src/a.ts'), makeFileItem('/src/b.ts')];
			widget.setEntries(entries);

			const setEntriesCalls: readonly IChatCollapsibleListItem[][] = [];
			const origSetEntries = widget.setEntries.bind(widget);
			widget.setEntries = (e) => {
				(setEntriesCalls as IChatCollapsibleListItem[][]).push([...e]);
				origSetEntries(e);
			};

			// Toggle to tree mode — should replay entries
			storageService.store(CHAT_EDITS_VIEW_MODE_STORAGE_KEY, 'tree', StorageScope.PROFILE, StorageTarget.USER);
			assert.strictEqual(setEntriesCalls.length, 1, 'setEntries should have been replayed');
			assert.strictEqual(setEntriesCalls[0].length, 2, 'should have replayed the 2 entries');

			widget.setEntries = origSetEntries;
		});

[dbaeumer]

@roblourens