Skip to content

fix: customize user-agent sent via macOS updater path#294646

Merged
deepak1556 merged 1 commit intomainfrom
robo/log_macos_updates
Feb 11, 2026
Merged

fix: customize user-agent sent via macOS updater path#294646
deepak1556 merged 1 commit intomainfrom
robo/log_macos_updates

Conversation

@deepak1556
Copy link
Collaborator

Fixes #288463

Based on the logs #288463 (comment) the headers from the auto updater client are having the expected Darwin/<kernel version> format. So I am unsure why the user got updates. However, in this change I am updating all our request sites on the macOS path with defined user agent that we control along with some logging.

@deepak1556 deepak1556 added this to the February 2026 milestone Feb 11, 2026
@deepak1556 deepak1556 self-assigned this Feb 11, 2026
Copilot AI review requested due to automatic review settings February 11, 2026 18:39
@deepak1556 deepak1556 enabled auto-merge (squash) February 11, 2026 18:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the macOS (Darwin) update flow to send a controlled User-Agent (including Darwin kernel version) across all update request paths, improving update-server EOL detection and adding diagnostics around update checks.

Changes:

  • Add getUpdateRequestHeaders() helper to generate macOS update request headers with a custom User-Agent.
  • Pass custom headers into Electron auto-updater feed configuration (setFeedURL) and into the manual “no auto-download” update check path.
  • Add additional auto-updater event wiring (checking-for-update) and extra tracing/logging around update checks and responses.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/vs/platform/update/electron-main/updateService.darwin.ts Apply custom headers to Electron autoUpdater feed, add metered “no-download” request headers, and add additional update-check logging/events.
src/vs/platform/update/electron-main/abstractUpdateService.ts Introduce shared macOS update header builder and apply it to isLatestVersion() request path, with extra tracing.

@deepak1556 deepak1556 force-pushed the robo/log_macos_updates branch from 4ef5d8a to dae83af Compare February 11, 2026 19:26
@deepak1556 deepak1556 merged commit 86aab8a into main Feb 11, 2026
18 checks passed
@deepak1556 deepak1556 deleted the robo/log_macos_updates branch February 11, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VS code Updated on MacOS 11.7.10 and then VS code broken

2 participants