fix: customize user-agent sent via macOS updater path#294646
Merged
deepak1556 merged 1 commit intomainfrom Feb 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the macOS (Darwin) update flow to send a controlled User-Agent (including Darwin kernel version) across all update request paths, improving update-server EOL detection and adding diagnostics around update checks.
Changes:
- Add
getUpdateRequestHeaders()helper to generate macOS update request headers with a custom User-Agent. - Pass custom headers into Electron auto-updater feed configuration (
setFeedURL) and into the manual “no auto-download” update check path. - Add additional auto-updater event wiring (
checking-for-update) and extra tracing/logging around update checks and responses.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/vs/platform/update/electron-main/updateService.darwin.ts | Apply custom headers to Electron autoUpdater feed, add metered “no-download” request headers, and add additional update-check logging/events. |
| src/vs/platform/update/electron-main/abstractUpdateService.ts | Introduce shared macOS update header builder and apply it to isLatestVersion() request path, with extra tracing. |
4ef5d8a to
dae83af
Compare
dmitrivMS
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #288463
Based on the logs #288463 (comment) the headers from the auto updater client are having the expected
Darwin/<kernel version>format. So I am unsure why the user got updates. However, in this change I am updating all our request sites on the macOS path with defined user agent that we control along with some logging.