Add compact layout support for Activity Bar #294881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces an opt-in compact layout mode for the Activity Bar by adding a new configuration setting and refactoring Activity Bar sizing to be driven by CSS custom properties, with accompanying unit tests to validate sizing and style updates.
Changes:
- Added
workbench.activityBar.compactsetting and registered it in the configuration schema. - Updated
ActivitybarPartand related CSS to support compact vs default sizing via CSS variables (width, action height, icon size). - Added browser unit tests to validate size constraints, CSS variables, and change events when toggling the setting.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/test/browser/parts/activitybar/activitybarPart.test.ts | Adds unit tests for compact/default sizing behavior and CSS variable updates. |
| src/vs/workbench/services/layout/browser/layoutService.ts | Introduces LayoutSettings.ACTIVITY_BAR_COMPACT constant. |
| src/vs/workbench/browser/workbench.contribution.ts | Registers the new workbench.activityBar.compact setting in the configuration schema. |
| src/vs/workbench/browser/parts/paneCompositeBar.ts | Updates URI icon mask sizing to allow overriding via --activity-bar-icon-size. |
| src/vs/workbench/browser/parts/activitybar/media/activitybarpart.css | Switches Activity Bar width to --activity-bar-width with fallback. |
| src/vs/workbench/browser/parts/activitybar/media/activityaction.css | Refactors Activity Bar action dimensions and icon size to CSS variables; adjusts badge/profile overlay for compact mode. |
| src/vs/workbench/browser/parts/activitybar/activitybarPart.ts | Implements compact mode toggling, updates min/max width constraints, sets CSS variables, and recreates the composite bar on change. |
| build/lib/stylelint/vscode-known-variables.json | Adds the new custom properties to the stylelint known-variables allowlist. |
lszomoru
approved these changes
Feb 12, 2026
Tyriar
reviewed
Feb 12, 2026
Comment on lines
216
to
219
| test('filter by command id', async () => { | ||
| const id = 'workbench.action.increaseViewSize'; | ||
| const id = 'workbench.action.view.size.' + uuid.generateUuid(); | ||
| registerCommandWithTitle(id, 'some title'); | ||
| prepareKeybindingService(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a compact layout option for the Activity Bar, allowing users to adjust dimensions and icon sizes. Refactor existing styles to utilize CSS variables for better customization and add unit tests to ensure proper functionality of the new layout features.