Adopt unified js/ts setting for suggest#295055
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Feb 12, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates TypeScript/JavaScript suggest-related settings from separate javascript.* and typescript.* configurations to a unified js/ts.* configuration scheme. This is part of a larger effort (#292934) to modernize and consolidate TypeScript language feature settings.
Changes:
- Added 12 new unified
js/ts.*suggest settings with appropriate tags (JavaScript/TypeScript) and language-overridable scope - Deprecated existing
javascript.*andtypescript.*versions of these settings with markdown deprecation messages - Updated all code to use the new
readUnifiedConfig()helper function, which checks the unified setting first before falling back to language-specific settings - Updated test utilities to reference the new unified setting names
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| extensions/typescript-language-features/package.json | Adds new unified js/ts.* suggest settings and marks old javascript.*/typescript.* versions as deprecated |
| extensions/typescript-language-features/package.nls.json | Adds localization strings for deprecation messages of old settings |
| extensions/typescript-language-features/src/languageProvider.ts | Updates suggestionActions.enabled to use readUnifiedConfig |
| extensions/typescript-language-features/src/languageFeatures/completions.ts | Updates completion-related settings (completeFunctionCalls, paths, autoImports, names, enabled) to use readUnifiedConfig |
| extensions/typescript-language-features/src/languageFeatures/fileConfigurationManager.ts | Updates multiple suggest settings in preferences (includeAutomaticOptionalChainCompletions, generateReturns, includeCompletionsForImportStatements, classMemberSnippets, objectLiteralMethodSnippets, autoImports) to use readUnifiedConfig |
| extensions/typescript-language-features/src/languageFeatures/jsDocCompletions.ts | Updates suggest.completeJSDocs to use readUnifiedConfig |
| extensions/typescript-language-features/src/test/testUtils.ts | Updates test configuration key from typescriptCompleteFunctionCalls to completeFunctionCalls to use the new unified setting name |
| extensions/typescript-language-features/src/test/smoke/completions.test.ts | Updates all test usages of completeFunctionCalls setting to use the new unified key |
Yoyokrazy
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #292934