Skip to content

Adopt unified js/ts setting for suggest#295055

Merged
mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz:dev/mjbvz/mighty-horse
Feb 12, 2026
Merged

Adopt unified js/ts setting for suggest#295055
mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz:dev/mjbvz/mighty-horse

Conversation

@mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Feb 12, 2026

Fixes #292934

Copilot AI review requested due to automatic review settings February 12, 2026 23:08
@mjbvz mjbvz self-assigned this Feb 12, 2026
@mjbvz mjbvz enabled auto-merge February 12, 2026 23:08
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 12, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates TypeScript/JavaScript suggest-related settings from separate javascript.* and typescript.* configurations to a unified js/ts.* configuration scheme. This is part of a larger effort (#292934) to modernize and consolidate TypeScript language feature settings.

Changes:

  • Added 12 new unified js/ts.* suggest settings with appropriate tags (JavaScript/TypeScript) and language-overridable scope
  • Deprecated existing javascript.* and typescript.* versions of these settings with markdown deprecation messages
  • Updated all code to use the new readUnifiedConfig() helper function, which checks the unified setting first before falling back to language-specific settings
  • Updated test utilities to reference the new unified setting names

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
extensions/typescript-language-features/package.json Adds new unified js/ts.* suggest settings and marks old javascript.*/typescript.* versions as deprecated
extensions/typescript-language-features/package.nls.json Adds localization strings for deprecation messages of old settings
extensions/typescript-language-features/src/languageProvider.ts Updates suggestionActions.enabled to use readUnifiedConfig
extensions/typescript-language-features/src/languageFeatures/completions.ts Updates completion-related settings (completeFunctionCalls, paths, autoImports, names, enabled) to use readUnifiedConfig
extensions/typescript-language-features/src/languageFeatures/fileConfigurationManager.ts Updates multiple suggest settings in preferences (includeAutomaticOptionalChainCompletions, generateReturns, includeCompletionsForImportStatements, classMemberSnippets, objectLiteralMethodSnippets, autoImports) to use readUnifiedConfig
extensions/typescript-language-features/src/languageFeatures/jsDocCompletions.ts Updates suggest.completeJSDocs to use readUnifiedConfig
extensions/typescript-language-features/src/test/testUtils.ts Updates test configuration key from typescriptCompleteFunctionCalls to completeFunctionCalls to use the new unified setting name
extensions/typescript-language-features/src/test/smoke/completions.test.ts Updates all test usages of completeFunctionCalls setting to use the new unified key

@mjbvz mjbvz merged commit 1ca6934 into microsoft:main Feb 12, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up JS/TS language specific setting settings

2 participants