layout - show toggled icons again for maximised panel/chat

[bpasero]

No description provided.

[Copilot]

Pull request overview

This PR refactors the panel and auxiliary bar maximize/restore actions by consolidating separate maximize and restore actions into single toggle actions with toggled states. The goal is to properly show toggled icons for maximized panels and chat (auxiliary bar).

Changes:

• Consolidated separate maximize and restore menu items into single toggle actions with toggled icon states
• Removed separate restoreIcon registrations and their associated menu entries
• Updated action configurations to use the toggled property for state-dependent icon and tooltip display

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
src/vs/workbench/browser/parts/panel/panelActions.ts	Removed restoreIcon, removed panelMaximizationSupportedWhen const, consolidated maximize/restore menu items into toggle action with toggled state
src/vs/workbench/browser/parts/auxiliarybar/auxiliaryBarActions.ts	Removed restoreIcon, removed icon/menu from separate maximize/restore actions, added toggled state to ToggleMaximizedAuxiliaryBar with icon and menu

Comments suppressed due to low confidence (1)

src/vs/workbench/browser/parts/auxiliarybar/auxiliaryBarActions.ts:277

• This tooltip uses a different localization key ('maximizeAuxiliaryBarTooltip2') than the MaximizeAuxiliaryBar action (line 226: 'maximizeAuxiliaryBarTooltip') with identical text ("Maximize Secondary Side Bar"). This creates unnecessary duplication in the localization strings. Consider reusing the existing 'maximizeAuxiliaryBarTooltip' key.

			tooltip: localize('maximizeAuxiliaryBarTooltip2', "Maximize Secondary Side Bar"),

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.