fix: skip binary/large files in chat repo info capture and disable by default#295253
Merged
fix: skip binary/large files in chat repo info capture and disable by default#295253
Conversation
zhichli
changed the title
false
roblourens
approved these changes
Feb 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the repository information capture feature's default configuration from true to false and adds file size limits with binary file detection to prevent processing of large or binary files when generating unified diffs for chat sessions.
Changes:
- Changed the default value of
ChatConfiguration.RepoInfoEnabledfromtruetofalsein both the configuration registry and the export action - Added a 1 MB file size limit (
MAX_FILE_SIZE_BYTES) for reading files during diff generation - Implemented binary file detection using
detectEncodingFromBufferto skip binary files - Enhanced error handling to properly catch and handle
FILE_TOO_LARGEerrors
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/electron-browser/actions/chatExportZip.ts | Changed fallback default for repoInfoEnabled from true to false |
| src/vs/workbench/contrib/chat/browser/chatRepoInfo.ts | Added file size limit constant, binary detection, size limit error handling, and changed configuration default to false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust file size limits to 1 MB and change the default setting for repository information capture to
falseFixes #294863