Skip to content

Comments

Persist chat tips disablement across workspaces#295806

Merged
meganrogge merged 2 commits intomainfrom
copilot/fix-chat-tips-preservation
Feb 17, 2026
Merged

Persist chat tips disablement across workspaces#295806
meganrogge merged 2 commits intomainfrom
copilot/fix-chat-tips-preservation

Conversation

Copy link
Contributor

Copilot AI commented Feb 17, 2026

Chat tips were disabled per workspace, causing them to reappear when opening another workspace. This change treats disablement as a user-level choice.

  • Configuration scope
    • Mark chat.tips.enabled as application-scoped so it is shared across workspaces.
  • Disable action
    • Persist disablement using the application configuration target.
  • Coverage
    • Add a unit test that asserts disableTips() writes to the application target.

Example:

await this._configurationService.updateValue('chat.tips.enabled', false, ConfigurationTarget.APPLICATION);
Original prompt

This section details on the original issue you should resolve

<issue_title>Disabling Chat tips should be preserved across workspaces</issue_title>
<issue_description>1. Open workspace, see Chat tips
2. Click on X to no longer show tips
3. Open another workspace. See chat tips again 🐛

Hiding tips should be preserved across workspaces (it is a user choice, not a workspace choice)

cc @roblourens </issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix chat tips to preserve user preferences across workspaces Persist chat tips disablement across workspaces Feb 17, 2026
Copilot AI requested a review from meganrogge February 17, 2026 17:49
@meganrogge meganrogge marked this pull request as ready for review February 17, 2026 17:49
Copilot AI review requested due to automatic review settings February 17, 2026 17:49
@meganrogge meganrogge enabled auto-merge (squash) February 17, 2026 17:49
@meganrogge meganrogge added this to the February 2026 milestone Feb 17, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where disabling chat tips was only persisted per-workspace, causing them to reappear when switching workspaces. The fix treats tip disablement as a user-level preference by using application-scoped configuration.

Changes:

  • Mark chat.tips.enabled configuration as application-scoped to share setting across all workspaces
  • Update disableTips() to persist the setting to ConfigurationTarget.APPLICATION instead of default target
  • Add unit test to verify that disablement writes to the application configuration target

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/vs/workbench/contrib/chat/browser/chat.contribution.ts Add scope: ConfigurationScope.APPLICATION to chat.tips.enabled setting definition
src/vs/workbench/contrib/chat/browser/chatTipService.ts Update disableTips() to use ConfigurationTarget.APPLICATION when persisting the setting
src/vs/workbench/contrib/chat/test/browser/chatTipService.test.ts Add TrackingConfigurationService test helper and new test to verify application target is used

@meganrogge meganrogge merged commit 59ab27f into main Feb 17, 2026
24 checks passed
@meganrogge meganrogge deleted the copilot/fix-chat-tips-preservation branch February 17, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disabling Chat tips should be preserved across workspaces

3 participants