fix sending new chat request in sessions window#295815
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a race condition when sending new chat requests in the sessions window. The issue occurred when the chat view pane was restoring a session (e.g., from onDidChangeAgents) while simultaneously trying to load a new session, causing the wrong session to be displayed.
Changes:
- Refactored
ChatViewPane.applyModel()to track in-progress session restoration viarestoringSessionpromise - Added synchronization in
ChatViewPane.loadSession()to wait for any in-progress restoration before loading a new session - Moved
isNewChatSessionContext.set(false)timing inSessionsWorkbenchService.openSession()to after model loading to prevent flickering - Added race condition handling in
SessionsWorkbenchService.openSessionAndSend()to wait for agent session creation with a 30-second timeout - Adjusted CSS padding for the chat editor from
0 10pxto0 6px 6px 6pxfor better visual spacing
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widgetHosts/viewPane/chatViewPane.ts | Refactored applyModel() to track restoration promise and added synchronization in loadSession() to prevent race conditions |
| src/vs/sessions/contrib/sessions/browser/sessionsWorkbenchService.ts | Delayed context key updates until after model loading and added Promise.race to wait for new session creation after send |
| src/vs/sessions/contrib/chat/browser/media/chatWidget.css | Adjusted editor padding to add bottom and horizontal spacing |
dmitrivMS
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.