Preserve question carousel across change of view#295826
Merged
meganrogge merged 3 commits intomainfrom Feb 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes issue #295472 where the question carousel would incorrectly show "Skipped" and cause the chat to hang when the user closed/moved the chat or changed editor tabs. The PR preserves the question carousel across view/editor switches within the same session while clearing it only when the session actually changes.
Changes:
- Modified carousel tracking to use session resources instead of clearing on all view model changes
- Removed forced
isUsedmutation on model reattach that caused false "Skipped" rendering - Added auto-resolution for unanswered carousels when a response completes
- Updated "Skipped" rendering to only show for explicitly ignored carousels, not auto-finalized ones
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts | Added session resource tracking and conditional carousel clearing based on session changes |
| src/vs/workbench/contrib/chat/browser/widget/chatWidget.ts | Removed forced isUsed mutation on model reattach and fixed input part reference in dismissPendingQuestionCarousel |
| src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts | Added auto-resolution logic for unanswered carousels when response completes |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatQuestionCarouselPart.ts | Changed "Skipped" message to only render when carousel.isUsed is true |
src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
roblourens
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #295472
Before:
before.mov
After:
chat-fix.mov
cc @justschen