Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes dead code that was accidentally included in PR #295402 (which focused on avoiding listener leak warnings). The changes remove unused TypeScript methods and CSS selectors that don't actually match any DOM elements in the chat widget.
Changes:
- Removed unused
renderParsedRequestToPlainTextmethod and its helpergetDecorationTitlefrom ChatMarkdownDecorationsRenderer - Removed CSS selectors for direct SPAN children of
.rendered-markdownin inline-progress contexts, which wouldn't match since markdown parsers wrap HTML in P tags
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/media/chat.css | Removed CSS selectors for .rendered-markdown:last-of-type > SPAN:empty that would never match due to markdown P-tag wrapping |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatMarkdownDecorationsRenderer.ts | Removed unused renderParsedRequestToPlainText and getDecorationTitle methods with no references in codebase |
Tyriar
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes were included with #295402, but shouldn't have been, due to multitasking in one workspace.