sessions - use activeSessionService for opening from picker#295984
Merged
sessions - use activeSessionService for opening from picker#295984
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the AgentSessionsPicker to support custom session opening logic in the Agent Sessions window. The Agent Sessions window (vs/sessions) is a standalone application layer with its own session management service (ISessionsManagementService) that needs to track active sessions differently than the default workbench behavior.
Changes:
- Added
IAgentSessionsPickerOptionsinterface with an optionaloverrideSessionOpencallback to allow custom session opening logic - Updated
AgentSessionsPickerconstructor to accept an optionaloptionsparameter - Modified
sessionsTitleBarWidget.tsto useactiveSessionService.openSession()when opening sessions from the picker in the Agent Sessions window - Updated all existing call sites to pass
undefinedfor the new options parameter to maintain backward compatibility
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsPicker.ts | Added IAgentSessionsPickerOptions interface and updated picker to conditionally call override function or default opener |
| src/vs/workbench/contrib/chat/browser/widgetHosts/viewPane/chatViewTitleControl.ts | Updated createInstance call to pass undefined for new options parameter |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsActions.ts | Updated createInstance call to pass undefined for new options parameter |
| src/vs/sessions/contrib/sessions/browser/sessionsTitleBarWidget.ts | Configured picker with overrideSessionOpen to use activeSessionService.openSession() for proper state management |
benibenj
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.