Fix quick dispose/reregister of tree view#295996
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a race condition that occurs when a tree view is quickly disposed and re-registered with the same ID. The async dispose operation could interfere with a newly registered tree view, causing the new view to be incorrectly disposed or preventing it from functioning properly.
Changes:
- Added identity check in dispose logic to prevent disposing a replacement tree view
- Moved
$disposeTreecall fromExtHostTreeView.dispose()to the wrapper dispose function - Added comprehensive test to verify the fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/api/common/extHostTreeViews.ts | Added check to only dispose tree view if it hasn't been replaced; moved $disposeTree call from internal class to wrapper |
| src/vs/workbench/api/test/browser/extHostTreeViews.test.ts | Added test case verifying dispose/re-register behavior works correctly |
bpasero
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.