Inline Compile & CompileCLI stages into platform specific jobs by joaomoreno · Pull Request #296006 · microsoft/vscode

joaomoreno · 2026-02-18T13:49:37Z

This PR eliminates both the Compile and the CompileCLI stage from our build, removing the overhead of transferring artifacts across jobs, which is now more than the time it takes to run the "meat" of those stages, now that they are faster (Compile now uses esbuild, CompileCLI now uses sccache).

We now have flat jobs, they can all start anew:

Product build:

CI build:

Also fixes #296465

Remove the standalone Compile stage from the ADO pipeline. Each platform job (Windows, Linux, macOS, Alpine, Web) now compiles TypeScript itself instead of downloading a shared Compilation artifact. - Add VSCODE_RUN_CHECKS parameter to Linux jobs for hygiene/lint/CG - Add VSCODE_RUN_COMPILE_EXTRAS parameter to macOS jobs for telemetry extraction and sourcemap upload - Remove VSCODE_COMPILE_ONLY parameter entirely - Delete product-compile.yml (no longer referenced) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

The macOS Universal app merge requires both x64 and arm64 builds to have identical file sets. Telemetry extraction was only running on arm64 (via VSCODE_RUN_COMPILE_EXTRAS), causing the universal merge to fail due to missing telemetry-core.json and telemetry-extensions.json in the x64 build. Move telemetry extraction outside the VSCODE_RUN_COMPILE_EXTRAS gate so it runs on all macOS builds. Sourcemap upload remains gated. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

All client builds (Linux, Windows, macOS) need telemetry-core.json and telemetry-extensions.json. Previously only macOS arm64 ran extract-telemetry. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Linux arm64 and armhf are server-only builds, no need for telemetry files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

The bash extract-telemetry.sh script fails on Windows because the Unix bin shim gets interpreted as Node.js code. Use a native PowerShell implementation that calls the extractor JS entry point directly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

The telemetry extractor may skip emitting declarations-resolved.json when no events are found. Handle this case with a warning instead of failing the build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

When each platform compiles independently, the build date embedded in cli.js (via INSERT_PRODUCT_CONFIGURATION) differs between machines because each uses new Date().toISOString(). This causes the macOS Universal app merge to fail since cli.js SHA differs between x64/arm64. Fix: use the git commit date (git log -1 --format=%cI HEAD) instead of the current wall-clock time. This ensures all independent builds on different machines produce identical timestamps. Updated in: - build/lib/date.ts: writeISODate() uses git commit date - build/next/index.ts: bundle(), transpile, and readISODate fallback all use git commit date Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR aims to make multi-machine/platform builds deterministic (notably for macOS Universal) by eliminating wall-clock build timestamps and by inlining the former shared “Compile” job into each platform-specific pipeline job.

Changes:

Switch build timestamp generation to use the git commit date (with wall-clock fallback) and reuse out-build/date where available.
Inline compilation into platform pipelines and remove the shared compilation artifact/job, updating stage wiring accordingly.
Adjust macOS universal merge behavior and some hygiene filters to accommodate the new pipeline outputs.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
build/next/index.ts	Uses git commit date for build timestamps; normalizes Windows paths in extension host bundle detection; reuses `out-build/date` when bundling.
build/lib/date.ts	Updates `writeISODate()` to use git commit date for deterministic timestamps.
build/filters.ts	Excludes additional paths/files from indentation hygiene.
build/darwin/create-universal-app.ts	Skips universal-merge comparison for telemetry JSON files.
build/azure-pipelines/win32/steps/product-build-win32-compile.yml	Removes downloading compile artifact; compiles in-place; validates outputs; generates telemetry lists.
build/azure-pipelines/web/product-build-web.yml	Removes downloading compile artifact; compiles in-place; validates outputs.
build/azure-pipelines/product-compile.yml	Removes the shared Compile job (deleted).
build/azure-pipelines/product-build.yml	Removes Compile stage and `VSCODE_COMPILE_ONLY`; updates stage dependencies/flags for new per-platform compilation.
build/azure-pipelines/product-build-macos.yml	Removes Compile stage dependency; enables compile extras in macOS CI.
build/azure-pipelines/linux/steps/product-build-linux-compile.yml	Inlines compilation; optionally runs full checks; validates outputs; generates telemetry on x64.
build/azure-pipelines/linux/product-build-linux.yml	Plumbs `VSCODE_RUN_CHECKS` into compile steps.
build/azure-pipelines/linux/product-build-linux-ci.yml	Enables `VSCODE_RUN_CHECKS` for Linux CI job variant.
build/azure-pipelines/darwin/steps/product-build-darwin-compile.yml	Inlines compilation; validates outputs; generates telemetry; optionally uploads sourcemaps via “compile extras”.
build/azure-pipelines/darwin/product-build-darwin.yml	Plumbs `VSCODE_RUN_COMPILE_EXTRAS` into compile steps.
build/azure-pipelines/darwin/product-build-darwin-ci.yml	Enables `VSCODE_RUN_COMPILE_EXTRAS` for macOS CI job variant.
build/azure-pipelines/common/publish.ts	Updates stage tracking to reflect removal of the Compile stage.
build/azure-pipelines/alpine/product-build-alpine.yml	Removes downloading compile artifact; compiles in-place; validates outputs.

build/next/index.ts

build/darwin/create-universal-app.ts

build/next/index.ts

core-ci (esbuild path) already includes cleanExtensionsBuildTask, compileNonNativeExtensionsBuildTask, and compileExtensionMediaBuildTask. Running extensions-ci in parallel caused a race condition where core-ci's rimraf of .build/extensions clashed with extensions-ci writing to the same directory. Also removes dead code: - extensions-ci and extensions-ci-pr task definitions (fully subsumed) - core-ci-old task (useEsbuildTranspile is always true) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…` function by exporting a single helper function from `build/lib/date.ts` and importing it in `build/next/index.ts` to ensure consistent behavior and improve code maintainability.

…ent date

…sistent output

…Script implementation

joaomoreno · 2026-02-20T16:23:17Z

src/vs/workbench/contrib/welcomeAgentSessions/browser/agentSessionsWelcome.ts

fyi @osortega

joaomoreno · 2026-02-20T16:23:33Z

src/vs/workbench/services/themes/browser/workbenchThemeService.ts

fyi @aeschli

- Remove centralized CompileCLI stage - Move CLI jobs into Windows, Linux, macOS stages as independent jobs - CLI jobs now compile, publish unsigned mid-job, sign, and publish signed - Platform compile jobs use deemon + waitForArtifacts for async CLI download - Delete separate CLI sign jobs (now merged into CLI compile jobs) - Remove CompileCLI from publish.ts stage tracking

…phire-ermine

joaomoreno · 2026-02-27T15:50:12Z

Final validation:

* chore: ralph loop checkpoint - 2026-02-17 12:48 * fix shell script * Inline compile stage into platform jobs Remove the standalone Compile stage from the ADO pipeline. Each platform job (Windows, Linux, macOS, Alpine, Web) now compiles TypeScript itself instead of downloading a shared Compilation artifact. - Add VSCODE_RUN_CHECKS parameter to Linux jobs for hygiene/lint/CG - Add VSCODE_RUN_COMPILE_EXTRAS parameter to macOS jobs for telemetry extraction and sourcemap upload - Remove VSCODE_COMPILE_ONLY parameter entirely - Delete product-compile.yml (no longer referenced) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Always run telemetry extraction on macOS builds The macOS Universal app merge requires both x64 and arm64 builds to have identical file sets. Telemetry extraction was only running on arm64 (via VSCODE_RUN_COMPILE_EXTRAS), causing the universal merge to fail due to missing telemetry-core.json and telemetry-extensions.json in the x64 build. Move telemetry extraction outside the VSCODE_RUN_COMPILE_EXTRAS gate so it runs on all macOS builds. Sourcemap upload remains gated. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Run telemetry extraction on all client builds All client builds (Linux, Windows, macOS) need telemetry-core.json and telemetry-extensions.json. Previously only macOS arm64 ran extract-telemetry. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Only run telemetry extraction on Linux x64 (client build) Linux arm64 and armhf are server-only builds, no need for telemetry files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Remove .ralph scaffolding files Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix telemetry extraction on Windows with native PowerShell The bash extract-telemetry.sh script fails on Windows because the Unix bin shim gets interpreted as Node.js code. Use a native PowerShell implementation that calls the extractor JS entry point directly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Handle missing telemetry files gracefully on Windows The telemetry extractor may skip emitting declarations-resolved.json when no events are found. Handle this case with a warning instead of failing the build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Use deterministic build date from git commit timestamp When each platform compiles independently, the build date embedded in cli.js (via INSERT_PRODUCT_CONFIGURATION) differs between machines because each uses new Date().toISOString(). This causes the macOS Universal app merge to fail since cli.js SHA differs between x64/arm64. Fix: use the git commit date (git log -1 --format=%cI HEAD) instead of the current wall-clock time. This ensures all independent builds on different machines produce identical timestamps. Updated in: - build/lib/date.ts: writeISODate() uses git commit date - build/next/index.ts: bundle(), transpile, and readISODate fallback all use git commit date Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Remove redundant extensions-ci task from CI pipelines core-ci (esbuild path) already includes cleanExtensionsBuildTask, compileNonNativeExtensionsBuildTask, and compileExtensionMediaBuildTask. Running extensions-ci in parallel caused a race condition where core-ci's rimraf of .build/extensions clashed with extensions-ci writing to the same directory. Also removes dead code: - extensions-ci and extensions-ci-pr task definitions (fully subsumed) - core-ci-old task (useEsbuildTranspile is always true) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * remove VSCODE_RUN_COMPILE_EXTRAS * address PR feedback regarding code duplication of `getGitCommitDate()` function by exporting a single helper function from `build/lib/date.ts` and importing it in `build/next/index.ts` to ensure consistent behavior and improve code maintainability. * update readISODate function to return git commit date instead of current date * add telemetry sorting script and integrate into build process for consistent output * refactor telemetry extraction process: replace shell script with TypeScript implementation * update skill * update telemetry-extractor dependency to version 1.19.0 * fix build * fix more duplicate telemetry definition issues * cleanup * refactor: consolidate validation checks into quality checks and remove obsolete tasks * bust the cache * undo cache bust * fix expression * fix * fix: update Azure storage account name in quality checks * fix: initialize stages set with 'Quality' * fix: add VSCODE_BUILD_TYPE parameter with options for Product and CI builds * fix: update Azure Pipeline CLI to use parameters instead of variables for queueing builds * fix: update VSCODE_BUILD_TYPE parameter values for clarity * fix: update default value for VSCODE_BUILD_TYPE parameter to 'Product' * leaner * even leaner * only npm ci in build * 💄 * run entire npm ci * fix * fix * fix it * Inline CompileCLI into platform stages - Remove centralized CompileCLI stage - Move CLI jobs into Windows, Linux, macOS stages as independent jobs - CLI jobs now compile, publish unsigned mid-job, sign, and publish signed - Platform compile jobs use deemon + waitForArtifacts for async CLI download - Delete separate CLI sign jobs (now merged into CLI compile jobs) - Remove CompileCLI from publish.ts stage tracking * fix: macOS CLI signing - use proper directory structure for ESRP * fix: add BUILDS_API_URL to Windows and Linux job templates * fix: label Linux CLI jobs clearly --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: João Moreno <22350+joaomoreno@users.noreply.github.com>

joaomoreno and others added 11 commits February 17, 2026 12:48

chore: ralph loop checkpoint - 2026-02-17 12:48

60cf84c

fix shell script

8e01b7b

Merge remote-tracking branch 'origin/main' into joao/sapphire-ermine

04fe8d8

Run telemetry extraction on all client builds

5857175

All client builds (Linux, Windows, macOS) need telemetry-core.json and telemetry-extensions.json. Previously only macOS arm64 ran extract-telemetry. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Only run telemetry extraction on Linux x64 (client build)

190706a

Linux arm64 and armhf are server-only builds, no need for telemetry files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Remove .ralph scaffolding files

b3ef297

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Handle missing telemetry files gracefully on Windows

3bd4069

The telemetry extractor may skip emitting declarations-resolved.json when no events are found. Handle this case with a warning instead of failing the build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 18, 2026 13:49

joaomoreno self-assigned this Feb 18, 2026

Copilot started reviewing on behalf of joaomoreno February 18, 2026 13:50 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

build/next/index.ts Show resolved Hide resolved

build/darwin/create-universal-app.ts Outdated Show resolved Hide resolved

build/next/index.ts Outdated Show resolved Hide resolved

joaomoreno and others added 10 commits February 18, 2026 15:20

remove VSCODE_RUN_COMPILE_EXTRAS

819aceb

address PR feedback regarding code duplication of `getGitCommitDate()…

6a8d087

…` function by exporting a single helper function from `build/lib/date.ts` and importing it in `build/next/index.ts` to ensure consistent behavior and improve code maintainability.

update readISODate function to return git commit date instead of curr…

3dbb357

…ent date

add telemetry sorting script and integrate into build process for con…

8598093

…sistent output

Merge remote-tracking branch 'origin/main' into joao/sapphire-ermine

3b71116

refactor telemetry extraction process: replace shell script with Type…

6b311c4

…Script implementation

update skill

fb705f8

update telemetry-extractor dependency to version 1.19.0

2c9a4f0

fix build

56fc84d

joaomoreno mentioned this pull request Feb 20, 2026

Telemetry tooling fails to report inconsistent telemetry events #296465

Closed

fix more duplicate telemetry definition issues

4ebab2d

joaomoreno commented Feb 20, 2026

View reviewed changes

src/vs/workbench/contrib/welcomeAgentSessions/browser/agentSessionsWelcome.ts

Copy link

Member Author

joaomoreno Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @osortega

joaomoreno commented Feb 20, 2026

View reviewed changes

src/vs/workbench/services/themes/browser/workbenchThemeService.ts

Copy link

Member Author

joaomoreno Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @aeschli

cleanup

1759c99

joaomoreno added 13 commits February 20, 2026 20:40

fix: update default value for VSCODE_BUILD_TYPE parameter to 'Product'

2f8cb42

leaner

6e917c6

even leaner

4f55de2

only npm ci in build

3c46565

💄

6f9fbbc

run entire npm ci

d896970

fix

17f8ec0

fix

799c315

fix it

b87b6af

fix: macOS CLI signing - use proper directory structure for ESRP

68fb6af

fix: add BUILDS_API_URL to Windows and Linux job templates

84a2702

fix: label Linux CLI jobs clearly

d633884

joaomoreno changed the title ~~Inline Compile job into platform specific jobs~~ Inline Compile & CompileCLI stages into platform specific jobs Feb 21, 2026

Merge commit 'a2860d1c314872c0c8c436647d10856fdd15f2bc' into joao/sap…

c90ef2c

…phire-ermine

austindyoung mentioned this pull request Feb 26, 2026

[mirror] microsoft/vscode#296006 Inline Compile & CompileCLI stages into platform specific jobs austindyoung/vscode-driftfence-mirror-fork#145

Open

Merge branch 'main' into joao/sapphire-ermine

a816629

joaomoreno added this to the March 2026 milestone Feb 27, 2026

joaomoreno added feature-request Request for new features or functionality engineering VS Code - Build / issue tracking / etc. labels Feb 27, 2026

joaomoreno marked this pull request as ready for review February 28, 2026 19:35

joaomoreno requested review from TylerLeonhardt, lszomoru and rzhao271 as code owners February 28, 2026 19:35

joaomoreno enabled auto-merge (squash) February 28, 2026 20:50

lszomoru approved these changes Mar 1, 2026

View reviewed changes

joaomoreno merged commit d2f1f7c into main Mar 1, 2026
91 checks passed

joaomoreno deleted the joao/sapphire-ermine branch March 1, 2026 07:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Inline Compile & CompileCLI stages into platform specific jobs#296006

Inline Compile & CompileCLI stages into platform specific jobs#296006
joaomoreno merged 48 commits intomainfrom
joao/sapphire-ermine

joaomoreno commented Feb 18, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joaomoreno Feb 20, 2026

Uh oh!

joaomoreno Feb 20, 2026

Uh oh!

joaomoreno commented Feb 27, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

joaomoreno commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joaomoreno Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

joaomoreno Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

joaomoreno commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

joaomoreno commented Feb 18, 2026 •

edited

Loading

joaomoreno commented Feb 27, 2026 •

edited

Loading