Skip to content

use sessionResource for edit source creation#296032

Merged
jrieken merged 1 commit intomainfrom
joh/hot-trout
Feb 18, 2026
Merged

use sessionResource for edit source creation#296032
jrieken merged 1 commit intomainfrom
joh/hot-trout

Conversation

@jrieken
Copy link
Member

@jrieken jrieken commented Feb 18, 2026

re #274403

Copilot AI review requested due to automatic review settings February 18, 2026 16:00
@jrieken jrieken enabled auto-merge (squash) February 18, 2026 16:01
@jrieken jrieken self-assigned this Feb 18, 2026
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 18, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is part of the larger migration effort (#274403) to use URIs instead of string IDs for tracking chat sessions throughout the VS Code codebase. This specific change updates the chatEditingTextModelChangeService.ts file to use the session resource URI when creating edit sources for telemetry purposes.

Changes:

  • Replaced the deprecated session.sessionId property with chatSessionResourceToId(session.sessionResource) for edit source creation
  • Added import for the chatSessionResourceToId utility function

@jrieken jrieken merged commit a4228a7 into main Feb 18, 2026
24 checks passed
@jrieken jrieken deleted the joh/hot-trout branch February 18, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments