Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression where dismissed tips would reappear after users re-enabled the tips feature. The issue was caused by duplicate tip IDs accumulating in storage (since dismissals were stored as a plain array), combined with a "safety valve" that reset dismissals when all tips were marked as dismissed, and a fallback that always returned a tip.
Changes:
- Added deduplication using Set when storing and retrieving dismissed tip IDs
- Added validation to only keep valid tip IDs (those in TIP_CATALOG)
- Removed the "safety valve" that reset dismissals to empty when all tips were dismissed
- Changed behavior to return
undefinedinstead of a fallback tip when all tips are dismissed - Added regression test to verify dismissed tips stay dismissed across disable/re-enable cycles
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/chatTipService.ts | Implemented deduplication in dismissTip() and _getDismissedTipIds(), removed reset logic and fallback tip selection |
| src/vs/workbench/contrib/chat/test/browser/chatTipService.test.ts | Added regression test verifying dismissed tips persist after disabling and re-enabling tips |
meganrogge
requested review from
TylerLeonhardt,
joaomoreno,
lszomoru and
rzhao271
as code owners
Collaborator
Author
|
Woah, something went wrong here 😅 |
auto-merge was automatically disabled
February 18, 2026 19:17
Pull request was closed
meganrogge
force-pushed
the
merogge/dismiss-tips
branch
from
31b66c6 to
e90983b
Compare
Yoyokrazy
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #296057
Dismissed tips were stored as a plain array, so duplicate IDs built up. A recovery check then treated “too many dismissed” as “none dismissed,” and a fallback always picked a tip, so previously dismissed tips could reappear after re-enabling tips.
We now dedupe persisted dismissals, only keep valid tip IDs, remove the reset-to-empty behavior, and return no tip when all are dismissed. That keeps dismissals persistent across disable/re-enable, and we added a regression test to lock this behavior.