Skip to content

adding prompt completions#296311

Draft
aiday-mar wants to merge 2 commits intomainfrom
inherent-shrew
Draft

adding prompt completions#296311
aiday-mar wants to merge 2 commits intomainfrom
inherent-shrew

Conversation

@aiday-mar
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings February 19, 2026 16:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the chat input editor to support “prompt completions” by enabling the inline completions contribution on the chat input CodeEditorWidget, and adjusting editor/model options to fit that experience.

Changes:

  • Adds InlineCompletionsController to the chat input editor’s contributions list.
  • Disables quickSuggestions for the chat input editor.
  • Changes the chat input model creation to use isForSimpleWidget = false.

let inputModel = this.modelService.getModel(this.inputUri);
if (!inputModel) {
inputModel = this.modelService.createModel('', null, this.inputUri, true);
inputModel = this.modelService.createModel('', null, this.inputUri, false);
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing createModel(..., /*isForSimpleWidget*/ false) makes the chat input text model eligible for synchronization to the extension host (shouldSynchronizeModel filters out only model.isForSimpleWidget). This is a significant behavior change: extensions will start receiving open/change events for chatSessionInput: documents, which can both expose user-entered prompts and add per-keystroke IPC/extension overhead. If the goal is to enable inline/prompt completions, consider keeping this model as a simple widget and proxy only the data needed for completions, or otherwise add an explicit rationale/guardrails for syncing this scheme to extensions.

Suggested change
inputModel = this.modelService.createModel('', null, this.inputUri, false);
// Mark as simple widget to avoid synchronizing chat input to the extension host
inputModel = this.modelService.createModel('', null, this.inputUri, true);

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants