Skip to content

Comments

Revert dmg-builder to version 26.5.0#296453

Merged
dbaeumer merged 2 commits intomainfrom
dbaeumer/complicated-carp-rose
Feb 20, 2026
Merged

Revert dmg-builder to version 26.5.0#296453
dbaeumer merged 2 commits intomainfrom
dbaeumer/complicated-carp-rose

Conversation

@dbaeumer
Copy link
Member

Revert the dmg-builder dependency to version 26.5.0 to address compatibility issues encountered with the newer version.

Copilot AI review requested due to automatic review settings February 20, 2026 07:03
@dbaeumer dbaeumer enabled auto-merge February 20, 2026 07:03
@dbaeumer dbaeumer self-assigned this Feb 20, 2026
deepak1556
deepak1556 previously approved these changes Feb 20, 2026
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 20, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request reverts the dmg-builder dependency from version 26.8.1 to 26.5.0 to address compatibility issues encountered with the newer version. The dmg-builder package is used in the macOS build process to create DMG installer images for VS Code.

Changes:

  • Downgrade dmg-builder dependency from 26.8.1 to 26.5.0 in build/package.json
Comments suppressed due to low confidence (1)

build/package.json:50

  • The package-lock.json file still references dmg-builder version 26.8.1 and needs to be updated to match the package.json change. After updating package.json, you need to run npm install to regenerate the package-lock.json file with the correct version. This includes updating the version reference at line 56, the main dmg-builder entry starting at line 4508, and potentially other transitive dependency references.
    "dmg-builder": "26.5.0",

@dbaeumer dbaeumer merged commit 9a697d7 into main Feb 20, 2026
27 of 29 checks passed
@dbaeumer dbaeumer deleted the dbaeumer/complicated-carp-rose branch February 20, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants