Confusing archive/delete UI elements across chat surfaces (fix #296405)#296461
Merged
Confusing archive/delete UI elements across chat surfaces (fix #296405)#296461
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the keycode string mapping for the Delete key to display as “Del” in UI labels while ensuring Electron accelerators still use “Delete”, and adjusts existing keyboard-mapper tests accordingly.
Changes:
- Update
KeyCode.DeleteUI label mapping from"Delete"to"Del"while keeping"Delete"as the user-settings label. - Special-case
KeyCode.DeleteinKeyCodeUtils.toElectronAcceleratorto return"Delete". - Update Linux keyboard mapper tests to expect
"Del"as the resolved label forDelete.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/services/keybinding/test/node/macLinuxKeyboardMapper.test.ts | Updates expected resolved label for Delete from "Delete" to "Del" in existing Linux keyboard event tests. |
| src/vs/base/common/keyCodes.ts | Changes KeyCode.Delete UI string to "Del", preserves "Delete" for user-settings parsing/printing, and ensures Electron accelerator remains "Delete". |
benibenj
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.