sessions - fix some issues found by AI#296463
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes several issues found by AI review in the Agent Sessions window codebase. The changes improve correctness and resource management by fixing an incorrect URL reference, removing unused parameters, and improving event listener disposal patterns.
Changes:
- Fixed incorrect dev URL reference from 'workbench.desktop.main.js' to 'sessions.desktop.main.js'
- Removed unused
editorGroupsContainerparameter from auxiliary titlebar constructors in both browser and electron implementations - Replaced manual event listener management with proper
MutableDisposablepattern for transitionend listener
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/sessions/electron-browser/sessions.ts | Corrects the dev-mode URL to load sessions.desktop.main.js instead of workbench.desktop.main.js |
| src/vs/sessions/electron-browser/parts/titlebarPart.ts | Removes unused editorGroupsContainer parameter from AuxiliaryNativeTitlebarPart constructor and prefixes parameter with underscore in doCreateAuxiliaryTitlebarPart |
| src/vs/sessions/contrib/sessions/browser/sessionsViewPane.ts | Improves event listener disposal by using MutableDisposable pattern instead of manual addEventListener/removeEventListener |
| src/vs/sessions/browser/parts/titlebarPart.ts | Removes unused editorGroupsContainer parameter from AuxiliaryTitlebarPart constructor and prefixes parameter with underscore in doCreateAuxiliaryTitlebarPart |
benibenj
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.