Skip to content

Comments

Polish Chat Model Picker Unavailable Entries#296474

Merged
isidorn merged 4 commits intomainfrom
isidor/chat-model-picker-polish
Feb 20, 2026
Merged

Polish Chat Model Picker Unavailable Entries#296474
isidorn merged 4 commits intomainfrom
isidor/chat-model-picker-polish

Conversation

@isidorn
Copy link
Collaborator

@isidorn isidorn commented Feb 20, 2026

Summary

  • adjust unavailable model wording from "Contact admin" to "Contact your admin"
  • change model picker filter placeholder from "Search models..." to "Search models"
  • cap displayed recently used models at 4 instead of 5
  • remove warning icon for unavailable "Update VS Code" and "Contact your admin" rows

Validation

  • ./scripts/test.sh
  • VS Code - Build watch tasks (Core - Transpile, Core - Typecheck, Ext - Build)

Copilot AI review requested due to automatic review settings February 20, 2026 09:18
@isidorn isidorn self-assigned this Feb 20, 2026
@isidorn isidorn requested a review from sandy081 February 20, 2026 09:19
@isidorn isidorn enabled auto-merge February 20, 2026 09:19
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 20, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR polishes the chat model picker UI/UX by refining unavailable-model messaging, search placeholder text, the “recently used” cap, and iconography to reduce visual noise.

Changes:

  • Update model picker strings (e.g., “Contact your admin”, “Search models”).
  • Reduce displayed “recently used” model IDs from 5 to 4.
  • Remove warning icons from the “Update VS Code” and “Contact your admin” unavailable rows (showing a blank icon instead).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/vs/workbench/contrib/chat/common/languageModels.ts Caps the returned recently-used model IDs to 4 entries.
src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts Adjusts unavailable row wording, removes warning icon usage for certain unavailable entries, and updates the filter placeholder string.

return this._recentlyUsedModelIds
.filter(id => this._modelCache.has(id) && id !== 'copilot/auto')
.slice(0, 5);
.slice(0, 4);
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getRecentlyUsedModelIds() is now hard-limited via .slice(0, 4), but the public interface documentation above still mentions a maxCount parameter (default 7). That JSDoc is misleading for consumers of ILanguageModelsService and should be updated (or the API should actually accept a maxCount argument) so documentation matches behavior.

Suggested change
.slice(0, 4);
.slice(0, 7);

Copilot uses AI. Check for mistakes.
description,
disabled: true,
group: { title: '', icon },
group: { title: '', icon: Codicon.blank },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to send a blank icon if we do not have icon

@isidorn isidorn merged commit 59489fa into main Feb 20, 2026
18 checks passed
@isidorn isidorn deleted the isidor/chat-model-picker-polish branch February 20, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants