Polish Chat Model Picker Unavailable Entries#296474
Conversation
There was a problem hiding this comment.
Pull request overview
This PR polishes the chat model picker UI/UX by refining unavailable-model messaging, search placeholder text, the “recently used” cap, and iconography to reduce visual noise.
Changes:
- Update model picker strings (e.g., “Contact your admin”, “Search models”).
- Reduce displayed “recently used” model IDs from 5 to 4.
- Remove warning icons from the “Update VS Code” and “Contact your admin” unavailable rows (showing a blank icon instead).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/languageModels.ts | Caps the returned recently-used model IDs to 4 entries. |
| src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts | Adjusts unavailable row wording, removes warning icon usage for certain unavailable entries, and updates the filter placeholder string. |
| return this._recentlyUsedModelIds | ||
| .filter(id => this._modelCache.has(id) && id !== 'copilot/auto') | ||
| .slice(0, 5); | ||
| .slice(0, 4); |
There was a problem hiding this comment.
getRecentlyUsedModelIds() is now hard-limited via .slice(0, 4), but the public interface documentation above still mentions a maxCount parameter (default 7). That JSDoc is misleading for consumers of ILanguageModelsService and should be updated (or the API should actually accept a maxCount argument) so documentation matches behavior.
| .slice(0, 4); | |
| .slice(0, 7); |
| description, | ||
| disabled: true, | ||
| group: { title: '', icon }, | ||
| group: { title: '', icon: Codicon.blank }, |
There was a problem hiding this comment.
no need to send a blank icon if we do not have icon
Summary
Validation