refactor: remove redundant 'id' property from model control entries in chat model picker

[sandy081]

No description provided.

[Copilot]

Pull request overview

This PR refactors the chat model picker to remove the redundant id property from IModelControlEntry. Since these entries are stored in dictionaries keyed by their ID, storing the ID again as a property was redundant. The refactoring extracts the ID from the dictionary key when needed and passes it separately where required.

Changes:

• Removed id property from IModelControlEntry interface
• Updated code to use dictionary keys (via Object.entries()) instead of entry.id
• Modified createUnavailableModelItem() to accept id as a separate parameter
• Updated all test fixtures to remove the redundant id property

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/vs/workbench/contrib/chat/common/languageModels.ts	Removed id from IModelControlEntry interface; updated _setModelsControlManifest() to not copy id into dictionary values
src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts	Changed featured models loop from Object.values() to Object.entries() to access keys; added id parameter to createUnavailableModelItem() and updated all call sites; updated PromotedItem type to include id for unavailable items
src/vs/workbench/contrib/chat/test/browser/widget/input/chatModelPicker.test.ts	Removed redundant id property from all test fixture data (17 occurrences)