refactor: remove upgradePlanUrl from model picker functions and tests#296537
Merged
refactor: remove upgradePlanUrl from model picker functions and tests#296537
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the model picker to use a centralized command link for the "Upgrade Plan" action instead of passing the upgradePlanUrl parameter through function calls. The change simplifies the function signatures by removing the upgradePlanUrl parameter and replaces dynamic URL generation with a hardcoded command link command:workbench.action.chat.upgradePlan.
Changes:
- Removed
upgradePlanUrlparameter frombuildModelPickerItemsandcreateUnavailableModelItemfunctions - Updated localization strings to use hardcoded command links instead of URL placeholders
- Updated all test call sites to match the new function signatures
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts | Removed upgradePlanUrl parameter from function signatures and replaced dynamic URL with command link in MarkdownStrings |
| src/vs/workbench/contrib/chat/test/browser/widget/input/chatModelPicker.test.ts | Updated test helper and direct test calls to remove upgradePlanUrl parameter |
src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts
Outdated
Show resolved
Hide resolved
sandy081
previously approved these changes
Feb 20, 2026
sandy081
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.